[GFI] Improve Vehicle Device Management

[roncodes]

Description:
Enhance the vehicle device management system to improve data integrity and usability.

Tasks:

• Add validation rules to ensure proper data consistency when attaching devices.
• Exclude devices that are already attached to other vehicles from the "Attach Device" dropdown or modal.
• Extend the functionality to support attaching sensors to vehicles as well.
• Update the UI to reflect new device and sensor relationships.
• Ensure backend validation prevents duplicate device assignments.

Acceptance Criteria:

• Users cannot attach the same device to multiple vehicles.
• Sensors can be attached and displayed similar to devices.
• Proper validation and error messages are shown to the user.

References:

• Related models: Device, Sensor, Vehicle.
• Relevant components: Device::Manager, Modals::AttachDevice.

[janni1288]

Hi, I'm starting to work on the vehicle device management issue and want to make sure I build on the right model before I go further.
While reading through the code I noticed there appear to be two separate models pointing at the same devices table:

• Device (server/src/Models/Device.php) - uses attachable_uuid/attachable_type (polymorphic), is used by DeviceController and has an attach()/detach() API endpoint.
• VehicleDevices (server/src/Models/VehicleDevice.php) - also protected $table = 'devices', but uses different fillable columns (vehicle_uuid, device_type, device_name, etc.) that don't seem to exist in the current devices migration.

Could you clarify:

1. Is VehicleDevice legacy/unused, and safe to ignore (or remove) while I work on this issue?
2. Is Device's attachable_* the correct, current model for vehicle <--> device attachment?
3. Which frontend component actually drives the "Attach Driver" modal referenced in the issue (Modals::AttachDrive/Device::Manager) - does it call /v1/devices/{id}/attach, or something else?

Want to avoid building validation on top of the wrong model. Happy to open a small separate PR to clean up VehicleDevice if it turns to be dead code.

[roncodes]

VehicleDevice is deprecated, this issue is more or less completed already and should actually be closed.

[janni1288]

Thanks for clarifying! Makes sense that VehicleDevice is deprecated - I'll leave that alone (happy to open a small separate PR to remove if that is welcome). One thing I want to double check before closing this out on my end: while reading through the current Device model and DeviceController::attach(), I noticed that attaching a device doesn't currently check whether it's already attached to a different vehicle - it silently reassigns attachable_uuid/attachable_type without any error or warning. So a user could accidentally "steal" a device from one vehicle while attaching it to another, with no feedback that this happened.
Is this something that's already handled elsewhere (e.g. filtered out in the frontend dropdown), or would a small PR adding this backend validation (reject re-attaching to a dropdown vehicle with a clear error, requiring an explicit detach first) still be useful?
Happy to open it either way you prefer.