From 8430283da3c84ddb22838e06e0bae090d2ac21a9 Mon Sep 17 00:00:00 2001 From: "denis.bilenko" Date: Thu, 12 Nov 2026 12:06:21 +0000 Subject: [PATCH] retry: say why the inactivity timeout is matched by message Follow-up to #7521 review. Co-authored-by: Isaac --- libs/retry/retry.go | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libs/retry/retry.go b/libs/retry/retry.go index 5c5e650a5d5..454a309016e 100644 --- a/libs/retry/retry.go +++ b/libs/retry/retry.go @@ -61,6 +61,9 @@ func IsTransient(ctx context.Context, err error) bool { // for HTTPTimeout ("request timed out after 1m30s of inactivity"). The SDK does not retry it. The // workspace files API stalls like this for a few minutes at a time; the server may or may not have // applied the request, which is the same uncertainty as a 504. +// +// We match the message because the SDK builds it with fmt.Errorf in httpclient/api_client.go +// and exports no sentinel error or type for it. func isInactivityTimeout(err error) bool { urlErr, ok := errors.AsType[*url.Error](err) if !ok {