From 56e6544faf32026e404c1db09399e14a1fabf93e Mon Sep 17 00:00:00 2001 From: Shreyas Goenka Date: Mon, 9 Nov 2026 13:22:55 +0000 Subject: [PATCH 1/2] testserver: accept Feature Store resources in DMS versions --- libs/testserver/bundledeployments.go | 1 + libs/testserver/bundledeployments_test.go | 43 +++++++++++++++++++++++ 2 files changed, 44 insertions(+) create mode 100644 libs/testserver/bundledeployments_test.go diff --git a/libs/testserver/bundledeployments.go b/libs/testserver/bundledeployments.go index 0eec1a4e463..e341789fb2a 100644 --- a/libs/testserver/bundledeployments.go +++ b/libs/testserver/bundledeployments.go @@ -50,6 +50,7 @@ var dmsResourceTypes = []string{ "database_instances", "experiments", "external_locations", + "features", "genie_spaces", "instance_pools", "internal_immutable_folders", diff --git a/libs/testserver/bundledeployments_test.go b/libs/testserver/bundledeployments_test.go new file mode 100644 index 00000000000..41444971767 --- /dev/null +++ b/libs/testserver/bundledeployments_test.go @@ -0,0 +1,43 @@ +package testserver_test + +import ( + "testing" + + "github.com/databricks/cli/libs/testserver" + "github.com/databricks/databricks-sdk-go" + "github.com/databricks/databricks-sdk-go/service/bundledeployments" + "github.com/stretchr/testify/assert" + "github.com/stretchr/testify/require" +) + +func TestCreateVersionAcceptsFeatureResource(t *testing.T) { + server := testserver.New(t) + testserver.AddDefaultHandlers(server) + client, err := databricks.NewWorkspaceClient(&databricks.Config{Host: server.URL, Token: "testtoken"}) + require.NoError(t, err) + ctx := t.Context() + const statePath = "/Workspace/dms-feature-test" + require.NoError(t, client.Workspace.MkdirsByPath(ctx, statePath)) + deployment, err := client.BundleDeployments.CreateDeployment(ctx, bundledeployments.CreateDeploymentRequest{ + Deployment: bundledeployments.Deployment{InitialParentPath: statePath}, + }) + require.NoError(t, err) + + version, err := client.BundleDeployments.CreateVersion(ctx, bundledeployments.CreateVersionRequest{ + Parent: deployment.Name, + VersionId: "1", + Version: bundledeployments.Version{ + VersionType: bundledeployments.VersionTypeVersionTypeDeploy, + Operations: []bundledeployments.StagedOperation{{ + ResourceKey: "features.feature1", + ActionType: bundledeployments.OperationActionTypeOperationActionTypeBind, + }}, + }, + }) + require.NoError(t, err) + operations, err := client.BundleDeployments.ListOperationsAll(ctx, bundledeployments.ListOperationsRequest{Parent: version.Name}) + require.NoError(t, err) + require.Len(t, operations, 1) + assert.Equal(t, "features.feature1", operations[0].ResourceKey) + assert.Equal(t, bundledeployments.OperationActionTypeOperationActionTypeBind, operations[0].ActionType) +} From 97fbd6bf31ebe9be9ddc9e9719d497900e02d106 Mon Sep 17 00:00:00 2001 From: Shreyas Goenka Date: Mon, 9 Nov 2026 14:50:17 +0000 Subject: [PATCH 2/2] Remove the DMS test-server regression test --- libs/testserver/bundledeployments_test.go | 43 ----------------------- 1 file changed, 43 deletions(-) delete mode 100644 libs/testserver/bundledeployments_test.go diff --git a/libs/testserver/bundledeployments_test.go b/libs/testserver/bundledeployments_test.go deleted file mode 100644 index 41444971767..00000000000 --- a/libs/testserver/bundledeployments_test.go +++ /dev/null @@ -1,43 +0,0 @@ -package testserver_test - -import ( - "testing" - - "github.com/databricks/cli/libs/testserver" - "github.com/databricks/databricks-sdk-go" - "github.com/databricks/databricks-sdk-go/service/bundledeployments" - "github.com/stretchr/testify/assert" - "github.com/stretchr/testify/require" -) - -func TestCreateVersionAcceptsFeatureResource(t *testing.T) { - server := testserver.New(t) - testserver.AddDefaultHandlers(server) - client, err := databricks.NewWorkspaceClient(&databricks.Config{Host: server.URL, Token: "testtoken"}) - require.NoError(t, err) - ctx := t.Context() - const statePath = "/Workspace/dms-feature-test" - require.NoError(t, client.Workspace.MkdirsByPath(ctx, statePath)) - deployment, err := client.BundleDeployments.CreateDeployment(ctx, bundledeployments.CreateDeploymentRequest{ - Deployment: bundledeployments.Deployment{InitialParentPath: statePath}, - }) - require.NoError(t, err) - - version, err := client.BundleDeployments.CreateVersion(ctx, bundledeployments.CreateVersionRequest{ - Parent: deployment.Name, - VersionId: "1", - Version: bundledeployments.Version{ - VersionType: bundledeployments.VersionTypeVersionTypeDeploy, - Operations: []bundledeployments.StagedOperation{{ - ResourceKey: "features.feature1", - ActionType: bundledeployments.OperationActionTypeOperationActionTypeBind, - }}, - }, - }) - require.NoError(t, err) - operations, err := client.BundleDeployments.ListOperationsAll(ctx, bundledeployments.ListOperationsRequest{Parent: version.Name}) - require.NoError(t, err) - require.Len(t, operations, 1) - assert.Equal(t, "features.feature1", operations[0].ResourceKey) - assert.Equal(t, bundledeployments.OperationActionTypeOperationActionTypeBind, operations[0].ActionType) -}