retryTo effect passes wrong indexes into callback

[danielrentz]

await retryTo(idx => {
  I.say(`try ${idx}`);
  I.see("nothing interesting");
}, 3);

logs

try 2
try 3
try 4

[kobenguyent]

* @example
 * const { retryTo } = require('codeceptjs/effects')
 * await retryTo((tries) => {
 *   if (tries < 3) {
 *     I.see('Non-existent element'); // Simulates a failure
 *   } else {
 *     I.see('Welcome'); // Succeeds on the 3rd attempt
 *   }
 * }, 5, 300); // Retry up to 5 times, with a 300ms interval
 *
 * @throws Will reject with the last error encountered if the maximum retries are exceeded.
 */
async function retryTo(callback, maxTries, pollInterval = 200) {

https://github.com/codeceptjs/CodeceptJS/blob/d18924b974a683c815fd57816e5645d737c98664/lib/effects.js#L190C2-L202C65

Isn't it expected like that if we look into the docs. 🤔

[danielrentz]

The current behavior does not match the example. I would read it as following

if (tries < 3) {

it runs two times into the if (for tries===1 and for tries===2)

} else {
    I.see('Welcome'); // Succeeds on the 3rd attempt

"succeeds on 3rd attempt" => runs into else for tries===3 which happens only when passing 1, 2, 3, ... instead of 2, 3, 4, ...

[kobenguyent]

eba4a62

Possibly, fixed by this commit.