From 6ddacdf5b05ac7e9f3861df46c08a48531044422 Mon Sep 17 00:00:00 2001 From: breki Date: Wed, 11 Nov 2026 13:43:52 +0000 Subject: [PATCH 1/2] instanced meshe children with overlays that use boundingspheres show up as invisible because IsAlwaysOn is false --- trinity/Eve/SpaceObject/Children/EveChildInstancedMeshes.cpp | 5 +++++ trinity/Eve/SpaceObject/Children/EveChildInstancedMeshes.h | 1 + 2 files changed, 6 insertions(+) diff --git a/trinity/Eve/SpaceObject/Children/EveChildInstancedMeshes.cpp b/trinity/Eve/SpaceObject/Children/EveChildInstancedMeshes.cpp index 3f3c9d643..fad7b1300 100644 --- a/trinity/Eve/SpaceObject/Children/EveChildInstancedMeshes.cpp +++ b/trinity/Eve/SpaceObject/Children/EveChildInstancedMeshes.cpp @@ -198,6 +198,11 @@ void EveChildInstancedMeshes::UpdateVisibility( const EveUpdateContext& updateCo m_lastInvLodFactor = updateContext.GetInvLodFactor(); } +bool EveChildInstancedMeshes::IsAlwaysOn() const +{ + return true; +} + void EveChildInstancedMeshes::GetRenderables( std::vector& renderables ) { // only overlay draws render here; the base hull goes through EveInstancedMeshManager diff --git a/trinity/Eve/SpaceObject/Children/EveChildInstancedMeshes.h b/trinity/Eve/SpaceObject/Children/EveChildInstancedMeshes.h index 490a9d6af..f480ceade 100644 --- a/trinity/Eve/SpaceObject/Children/EveChildInstancedMeshes.h +++ b/trinity/Eve/SpaceObject/Children/EveChildInstancedMeshes.h @@ -39,6 +39,7 @@ BLUE_CLASS( EveChildInstancedMeshes ) : void GetLocalToWorldTransform( Matrix & transform ) const override; void Setup( const Vector3* scale, const Quaternion* rotation, const Vector3* translation, Tr2Lod lowestLodVisible ) override; void SetShaderOption( const BlueSharedString& name, const BlueSharedString& value ) override; + bool IsAlwaysOn() const override; ////////////////////////////////////////////////////////////////////////////////////// From cd756c8793a5d2374368df0c7f922c56f44f7c10 Mon Sep 17 00:00:00 2001 From: Breki Ingibjargarson Date: Wed, 11 Nov 2026 14:38:09 +0000 Subject: [PATCH 2/2] Update trinity/Eve/SpaceObject/Children/EveChildInstancedMeshes.h Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> --- trinity/Eve/SpaceObject/Children/EveChildInstancedMeshes.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/trinity/Eve/SpaceObject/Children/EveChildInstancedMeshes.h b/trinity/Eve/SpaceObject/Children/EveChildInstancedMeshes.h index f480ceade..40b8e66a9 100644 --- a/trinity/Eve/SpaceObject/Children/EveChildInstancedMeshes.h +++ b/trinity/Eve/SpaceObject/Children/EveChildInstancedMeshes.h @@ -36,7 +36,7 @@ BLUE_CLASS( EveChildInstancedMeshes ) : bool GetBoundingSphere( Vector4 & sphere, BoundingSphereQuery query = EVE_BOUNDS_NORMAL ) const override; void UpdateSyncronous( const EveUpdateContext& updateContext, const EveChildUpdateParams& params ) override; void UpdateAsyncronous( const EveUpdateContext& updateContext, const EveChildUpdateParams& params ) override; - void GetLocalToWorldTransform( Matrix & transform ) const override; + void GetLocalToWorldTransform( Matrix& transform ) const override; void Setup( const Vector3* scale, const Quaternion* rotation, const Vector3* translation, Tr2Lod lowestLodVisible ) override; void SetShaderOption( const BlueSharedString& name, const BlueSharedString& value ) override; bool IsAlwaysOn() const override;