From aff76bcb32f111eb468239af49a4da40a94e5140 Mon Sep 17 00:00:00 2001
From: kavishka-venuka <kavishkavenuka554pro@gmail.com>
Date: Mon, 21 Sep 2026 02:20:07 +0530
Subject: [PATCH] fix(samples): add missing onClick handler and remove invalid
 signInUrl in tanstack-router sample

---
 samples/react-tanstack-router/src/main.tsx       |  2 --
 samples/react-tanstack-router/src/pages/Home.tsx | 12 ++++++++++--
 2 files changed, 10 insertions(+), 4 deletions(-)

diff --git a/samples/react-tanstack-router/src/main.tsx b/samples/react-tanstack-router/src/main.tsx
index 9edd43c4c..62c63157c 100644
--- a/samples/react-tanstack-router/src/main.tsx
+++ b/samples/react-tanstack-router/src/main.tsx
@@ -39,8 +39,6 @@ createRoot(document.getElementById('root')!).render(
     <AsgardeoProvider
       baseUrl={import.meta.env.VITE_ASGARDEO_BASE_URL}
       clientId={import.meta.env.VITE_ASGARDEO_CLIENT_ID}
-      signInUrl="/signin"
-      signUpUrl="/signup"
       scopes="openid profile email"
     >
       <RouterProvider router={router} />
diff --git a/samples/react-tanstack-router/src/pages/Home.tsx b/samples/react-tanstack-router/src/pages/Home.tsx
index f189dd34b..cf1019805 100644
--- a/samples/react-tanstack-router/src/pages/Home.tsx
+++ b/samples/react-tanstack-router/src/pages/Home.tsx
@@ -19,7 +19,11 @@ export default function Home() {
             </>
           ) : (
             <SignInButton>
-              {({isLoading}) => <button disabled={isLoading}>{isLoading ? 'Loading...' : 'Sign In'}</button>}
+              {({isLoading, signIn}) => (
+                <button onClick={signIn} disabled={isLoading}>
+                  {isLoading ? 'Loading...' : 'Sign In'}
+                </button>
+              )}
             </SignInButton>
           )}
         </div>
@@ -34,7 +38,11 @@ export default function Home() {
         {!isSignedIn && (
           <div>
             <SignInButton>
-              {({isLoading}) => <button disabled={isLoading}>{isLoading ? 'Loading...' : 'Get Started'}</button>}
+              {({isLoading, signIn}) => (
+                <button onClick={signIn} disabled={isLoading}>
+                  {isLoading ? 'Loading...' : 'Get Started'}
+                </button>
+              )}
             </SignInButton>
           </div>
         )}