Skip to content

No Error handling for Deserialize method which ends up crashing Node JS #422

Description

@kotharishreyb2

Hello Team

Here I am trying to serialize and deserialize messageId for my business use case

but issue is for proper error handling if in case we pass invalid buffer data to MessageId.deserialize method then it throws C++ exception
libc++abi: terminating due to uncaught exception of type std::invalid_argument: Failed to parse serialized message id
which is not handled by pulsar-client and node JS crashes

I see similar issue was there while creating a client too but that got fixed with this issue and PR https://github.com/apache/pulsar-client-node/pull/307/files
where it was wrapped with try catch block
but deserialize method is still not fixed

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions