From e7901d410e68cc51aa563fc7799eee983e775507 Mon Sep 17 00:00:00 2001 From: Yixin Date: Thu, 5 Nov 2026 13:01:37 -0800 Subject: [PATCH] fix(evaluators): use galileo-core Span alias for child spans galileo-core 4.6.0 added HttpSpan to the Span union that ToolSpan, RetrieverSpan and Trace accept in `spans`. The local copy of the union lacked it, and list is invariant, so mypy rejected the child-span list. Use the SDK's own Span alias so the type follows the installed version. Co-Authored-By: Claude --- .../agent_control_evaluator_galileo/records/factory.py | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/evaluators/contrib/galileo/src/agent_control_evaluator_galileo/records/factory.py b/evaluators/contrib/galileo/src/agent_control_evaluator_galileo/records/factory.py index 75a3e5b6..59fb62b5 100644 --- a/evaluators/contrib/galileo/src/agent_control_evaluator_galileo/records/factory.py +++ b/evaluators/contrib/galileo/src/agent_control_evaluator_galileo/records/factory.py @@ -8,12 +8,10 @@ from agent_control_models import Step from galileo_core.schemas.logging.session import Session from galileo_core.schemas.logging.span import ( - AgentSpan, - ControlSpan, LlmSpan, RetrieverSpan, + Span, ToolSpan, - WorkflowSpan, ) from galileo_core.schemas.logging.trace import Trace @@ -21,7 +19,6 @@ type GalileoRecord = LlmSpan | ToolSpan | RetrieverSpan | Trace | Session type GalileoSpan = LlmSpan | ToolSpan | RetrieverSpan -type GalileoCoreSpan = AgentSpan | WorkflowSpan | LlmSpan | RetrieverSpan | ToolSpan | ControlSpan _MISSING = object() _SPAN_TYPES = {"llm", "tool", "retriever"} _RECORD_TYPES = _SPAN_TYPES | {"trace", "session"} @@ -54,8 +51,8 @@ def _selected_values( return selected_data, None -def _span_children(children: list[GalileoRecord], *, parent_type: str) -> list[GalileoCoreSpan]: - spans: list[GalileoCoreSpan] = [] +def _span_children(children: list[GalileoRecord], *, parent_type: str) -> list[Span]: + spans: list[Span] = [] for child in children: if not isinstance(child, (LlmSpan, ToolSpan, RetrieverSpan)): raise RecordFactoryError(f"Galileo {parent_type} children must be span steps.")