From 45ae6bdacb616072880fb93cea2955fbed21f67c Mon Sep 17 00:00:00 2001
From: "vivi-the-going-merry[bot]"
 <308115520+vivi-the-going-merry[bot]@users.noreply.github.com>
Date: Fri, 25 Sep 2026 05:17:50 -0600
Subject: [PATCH] Remove dangling label for= on 22 more styles-page headings

Follow-up to #3366/#3463 (formidable-pro#6709): FrmSliderStyleComponent's
template always puts the caller's 'id' on a type="hidden" storage input,
never on a visible/labelable control, so any for="<that id>" heading is
dangling by construction. FrmAlignStyleComponent silently discards 'id'
entirely (same defect, different flavor).

20 slider-based instances across 7 files not touched by #3463 (_buttons.php
alone has 7), matching Franky's Sept 19 DOM-confirmed count on #3366. Plus
2 more Align-based instances (_field-description.php, _field-labels.php)
outside that slider-only scope, same root cause.

Fix matches established precedent exactly: drop the dangling for=, keep
'id' on slider calls (still used by js/admin/style.js's getElementById
lookup on the hidden input), drop 'id' on the two Align calls (confirmed
unused anywhere in js/).
---
 classes/views/styles/_buttons.php                |  7 -------
 classes/views/styles/_check-box-radio-fields.php |  3 +--
 classes/views/styles/_field-colors.php           |  2 --
 classes/views/styles/_field-description.php      | 10 +++-------
 classes/views/styles/_field-labels.php           |  5 -----
 classes/views/styles/_form-description.php       |  3 +--
 classes/views/styles/_form-messages.php          |  2 --
 classes/views/styles/_form-title.php             |  6 ++----
 8 files changed, 7 insertions(+), 31 deletions(-)

diff --git a/classes/views/styles/_buttons.php b/classes/views/styles/_buttons.php
index f2b9413f5a..36ad9cc90f 100644
--- a/classes/views/styles/_buttons.php
+++ b/classes/views/styles/_buttons.php
@@ -53,7 +53,6 @@ class="frm-style-item-heading"><?php esc_html_e( 'Font Color', 'formidable' ); ?
 
 					<div class="frm5 frm_form_field">
 						<label
-							for="frm_submit_font_size"
 							class="frm-style-item-heading"><?php esc_html_e( 'Font Size', 'formidable' ); ?></label>
 					</div>
 					<div class="frm7 frm_form_field">
@@ -89,7 +88,6 @@ class="frm-style-item-heading"><?php esc_html_e( 'Weight', 'formidable' ); ?></l
 
 					<div class="frm5 frm_form_field">
 						<label
-							for="frm_submit_width"
 							class="frm-style-item-heading"><?php esc_html_e( 'Width', 'formidable' ); ?></label>
 					</div>
 					<div class="frm7 frm_form_field">
@@ -108,7 +106,6 @@ class="frm-style-item-heading"><?php esc_html_e( 'Width', 'formidable' ); ?></la
 
 					<div class="frm5 frm_form_field">
 						<label
-							for="frm_submit_height"
 							class="frm-style-item-heading"><?php esc_html_e( 'Height', 'formidable' ); ?></label>
 					</div>
 					<div class="frm7 frm_form_field">
@@ -145,7 +142,6 @@ class="frm-style-item-heading"><?php esc_html_e( 'Border Color', 'formidable' );
 
 					<div class="frm5 frm_form_field">
 						<label
-							for="frm_submit_border_width"
 							class="frm-style-item-heading"><?php esc_html_e( 'Border Width', 'formidable' ); ?></label>
 					</div>
 					<div class="frm7 frm_form_field">
@@ -181,7 +177,6 @@ class="frm-style-item-heading"><?php esc_html_e( 'Shadow', 'formidable' ); ?></l
 
 					<div class="frm5 frm_form_field">
 						<label
-							for="frm_submit_border_radius"
 							class="frm-style-item-heading"><?php esc_html_e( 'Corner Radius', 'formidable' ); ?></label>
 					</div>
 					<div class="frm7 frm_form_field">
@@ -199,7 +194,6 @@ class="frm-style-item-heading"><?php esc_html_e( 'Corner Radius', 'formidable' )
 
 					<div class="frm5 frm_form_field">
 						<label
-							for="frm_submit_margin"
 							class="frm-style-item-heading">
 							<?php esc_html_e( 'Margin', 'formidable' ); ?>
 							<span class="frm_help frmfont frm_tooltip_icon" data-placement="right" data-container="body" data-original-title="<?php esc_attr_e( 'Used for navigation buttons too', 'formidable' ); ?>"></span>
@@ -221,7 +215,6 @@ class="frm-style-item-heading">
 
 					<div class="frm5 frm_form_field">
 						<label
-							for="frm_submit_padding"
 							class="frm-style-item-heading">
 							<?php esc_html_e( 'Padding', 'formidable' ); ?>
 						</label>
diff --git a/classes/views/styles/_check-box-radio-fields.php b/classes/views/styles/_check-box-radio-fields.php
index df144b735b..cbf61035c6 100644
--- a/classes/views/styles/_check-box-radio-fields.php
+++ b/classes/views/styles/_check-box-radio-fields.php
@@ -22,8 +22,7 @@ class="frm-style-item-heading"><?php esc_html_e( 'Color', 'formidable' ); ?></la
 </div>
 
 <div class="frm5 frm_form_field">
-	<label 
-		for="frm_check_font_size"
+	<label
 		class="frm-style-item-heading"><?php esc_html_e( 'Font Size', 'formidable' ); ?></label>
 </div>
 <div class="frm7 frm_form_field">
diff --git a/classes/views/styles/_field-colors.php b/classes/views/styles/_field-colors.php
index 6b4bfe9268..61bc46554d 100644
--- a/classes/views/styles/_field-colors.php
+++ b/classes/views/styles/_field-colors.php
@@ -75,7 +75,6 @@ class="frm-style-item-heading"><?php esc_html_e( 'Border', 'formidable' ); ?></l
 
 					<div class="frm5 frm_form_field">
 						<label
-							for="frm_field_border_width"
 							class="frm-style-item-heading"><?php esc_html_e( 'Border Width', 'formidable' ); ?></label>
 					</div>
 					<div class="frm7 frm_form_field">
@@ -310,7 +309,6 @@ class="frm-style-item-heading"><?php esc_html_e( 'Border', 'formidable' ); ?></l
 
 					<div class="frm5 frm_form_field">
 						<label
-							for="frm_border_width_error"
 							class="frm-style-item-heading"><?php esc_html_e( 'Border Width', 'formidable' ); ?></label>
 					</div>
 					<div class="frm7 frm_form_field">
diff --git a/classes/views/styles/_field-description.php b/classes/views/styles/_field-description.php
index 6de066c648..83e1170f06 100644
--- a/classes/views/styles/_field-description.php
+++ b/classes/views/styles/_field-description.php
@@ -22,8 +22,7 @@ class="frm-style-item-heading"><?php esc_html_e( 'Color', 'formidable' ); ?></la
 </div>
 
 <div class="frm5 frm_form_field">
-	<label 
-		for="frm_description_font_size"
+	<label
 		class="frm-style-item-heading"><?php esc_html_e( 'Font Size', 'formidable' ); ?></label>
 </div>
 <div class="frm7 frm_form_field">
@@ -79,8 +78,7 @@ class="frm-style-item-heading"><?php esc_html_e( 'Style', 'formidable' ); ?></la
 </div>
 
 <div class="frm5 frm_form_field">
-	<label 
-		for="frm_description_align"
+	<label
 		class="frm-style-item-heading"><?php esc_html_e( 'Align', 'formidable' ); ?></label>
 </div>
 <div class="frm7 frm_form_field frm-sm-z-index">
@@ -89,7 +87,6 @@ class="frm-style-item-heading"><?php esc_html_e( 'Align', 'formidable' ); ?></la
 		$frm_style->get_field_name( 'description_align' ),
 		$style->post_content['description_align'],
 		array(
-			'id'      => 'frm_description_align',
 			'options' => array( 'left', 'right' ),
 		)
 	);
@@ -97,8 +94,7 @@ class="frm-style-item-heading"><?php esc_html_e( 'Align', 'formidable' ); ?></la
 </div>
 
 <div class="frm5 frm_form_field">
-	<label 
-		for="frm_description_margin"
+	<label
 		class="frm-style-item-heading"><?php esc_html_e( 'Margin', 'formidable' ); ?></label>
 </div>
 <div class="frm7 frm_form_field frm-md-z-index">
diff --git a/classes/views/styles/_field-labels.php b/classes/views/styles/_field-labels.php
index 18fc1e79b8..7922facbe3 100644
--- a/classes/views/styles/_field-labels.php
+++ b/classes/views/styles/_field-labels.php
@@ -37,7 +37,6 @@ class="frm-style-item-heading"><?php esc_html_e( 'Color', 'formidable' ); ?></la
 
 					<div class="frm5 frm_form_field">
 						<label
-							for="frm_font_size"
 							class="frm-style-item-heading"><?php esc_html_e( 'Font Size', 'formidable' ); ?></label>
 					</div>
 					<div class="frm7 frm_form_field">
@@ -91,7 +90,6 @@ class="frm-style-item-heading"><?php esc_html_e( 'Position', 'formidable' ); ?><
 
 					<div class="frm5 frm_form_field">
 						<label
-							for="frm_label_align"
 							class="frm-style-item-heading"><?php esc_html_e( 'Align', 'formidable' ); ?></label>
 					</div>
 					<div class="frm7 frm_form_field frm-sm-z-index">
@@ -100,7 +98,6 @@ class="frm-style-item-heading"><?php esc_html_e( 'Align', 'formidable' ); ?></la
 							$frm_style->get_field_name( 'align' ),
 							$style->post_content['align'],
 							array(
-								'id'      => 'frm_label_align',
 								'options' => array( 'left', 'right' ),
 							)
 						);
@@ -109,7 +106,6 @@ class="frm-style-item-heading"><?php esc_html_e( 'Align', 'formidable' ); ?></la
 
 					<div class="frm5 frm_form_field">
 						<label
-							for="frm_width"
 							class="frm-style-item-heading"><?php esc_html_e( 'Width', 'formidable' ); ?></label>
 					</div>
 					<div class="frm7 frm_form_field frm-md-z-index">
@@ -127,7 +123,6 @@ class="frm-style-item-heading"><?php esc_html_e( 'Width', 'formidable' ); ?></la
 
 					<div class="frm5 frm_form_field">
 						<label
-							for="frm_label_padding"
 							class="frm-style-item-heading"><?php esc_html_e( 'Padding', 'formidable' ); ?></label>
 					</div>
 					<div class="frm7 frm_form_field">
diff --git a/classes/views/styles/_form-description.php b/classes/views/styles/_form-description.php
index 3608094cae..2a7461c1c7 100644
--- a/classes/views/styles/_form-description.php
+++ b/classes/views/styles/_form-description.php
@@ -5,8 +5,7 @@
 ?>
 
 <div class="frm5 frm_form_field">
-	<label 
-		for="frm_form_desc_size"
+	<label
 		class="frm-style-item-heading"><?php esc_html_e( 'Font Size', 'formidable' ); ?>
 	</label>
 </div>
diff --git a/classes/views/styles/_form-messages.php b/classes/views/styles/_form-messages.php
index 99bf728d1f..0efc4aa3da 100644
--- a/classes/views/styles/_form-messages.php
+++ b/classes/views/styles/_form-messages.php
@@ -73,7 +73,6 @@ class="frm-style-item-heading"><?php esc_html_e( 'Font Color', 'formidable' ); ?
 
 					<div class="frm5 frm_form_field">
 						<label
-							for="frm_success_font_size"
 							class="frm-style-item-heading"><?php esc_html_e( 'Font Size', 'formidable' ); ?></label>
 					</div>
 					<div class="frm7 frm_form_field">
@@ -149,7 +148,6 @@ class="frm-style-item-heading"><?php esc_html_e( 'Font Color', 'formidable' ); ?
 
 					<div class="frm5 frm_form_field">
 						<label
-							for="frm_error_font_size"
 							class="frm-style-item-heading"><?php esc_html_e( 'Font Size', 'formidable' ); ?></label>
 					</div>
 					<div class="frm7 frm_form_field">
diff --git a/classes/views/styles/_form-title.php b/classes/views/styles/_form-title.php
index be28362bdc..0ecf124b79 100644
--- a/classes/views/styles/_form-title.php
+++ b/classes/views/styles/_form-title.php
@@ -22,8 +22,7 @@ class="frm-style-item-heading"><?php esc_html_e( 'Color', 'formidable' ); ?></la
 </div>
 
 <div class="frm5 frm_form_field">
-	<label 
-		for="frm_title_size"
+	<label
 		class="frm-style-item-heading"><?php esc_html_e( 'Font Size', 'formidable' ); ?></label>
 </div>
 <div class="frm7 frm_form_field">
@@ -40,8 +39,7 @@ class="frm-style-item-heading"><?php esc_html_e( 'Font Size', 'formidable' ); ?>
 </div>
 
 <div class="frm5 frm_form_field">
-	<label 
-		for="frm_title_margins"
+	<label
 		class="frm-style-item-heading"><?php esc_html_e( 'Margin', 'formidable' ); ?></label>
 </div>
 <div class="frm7 frm_form_field">