Skip to content

Commit d143dbb

Browse files
kdaviduikclaude
andcommitted
fix: address review feedback
- Update docs/index.md browser support table to reflect dropped IE 11 - Add comment to .babelrc explaining retained modules-commonjs plugin - Expand changeset with migration guidance for affected users Co-Authored-By: Claude <noreply@anthropic.com>
1 parent c866900 commit d143dbb

4 files changed

Lines changed: 12 additions & 4 deletions

File tree

.babelrc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
],
88
"env": {
99
"development": {
10+
// Retained for Browserify/testem test pipeline — removed in PR 7a when Vitest replaces Browserify
1011
"plugins": [
1112
"@babel/plugin-transform-modules-commonjs"
1213
]

.changeset/drop-ie11-modernize-targets.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,3 +3,8 @@
33
---
44

55
Drop IE 11, Safari 8, iOS 8, Android 4.4 browser support. Minimum browser targets are now rolling modern versions aligned with Shopify Online Store themes. The library now emits ES2015+ JavaScript (native classes, arrow functions, template literals) and no longer transpiles to ES5.
6+
7+
**Migration guide:**
8+
- If you need IE 11 support, pin to `@shopify/buy-button-js@^3.0.0`.
9+
- If you use the CDN `latest` URL (`sdks.shopifycdn.com/buy-button/latest/buybutton.js`), pin to a specific 3.x version before upgrading.
10+
- If your site relied on buy-button-js to provide `fetch`, `Promise`, or ES6 array/object polyfills as a side effect, you must now provide your own polyfills.

docs/index.md

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,11 @@ This tool is intended for use by developers who are familiar with JavaScript and
1717

1818
## Current Support
1919

20-
| Internet Explorer | Chrome, Edge, Firefox, Opera | Safari | iOS | Android |
21-
| :-------------------- | :------------------------------- | :-------- | :------ | :-------- |
22-
| 11+ | (Current - 1) or Current | 8+ | 8+ | 4.4+
20+
| Chrome | Firefox | Safari | Edge | iOS | Android |
21+
| :----- | :------ | :----- | :--- | :-- | :------ |
22+
| Last 3 | Last 3 | Last 3 | Last 3 | 13.4+ | Last 3 Chrome |
23+
24+
> **Note (v4.0.0+):** Internet Explorer, Safari 8, iOS 8, and Android 4.4 are no longer supported. If you need IE 11 support, pin to v3.x.
2325
2426
## Including the library
2527

src/styles/host/host.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)