Skip to content

Commit 041de3f

Browse files
committed
docs: fix stale counts and PR number coupling in documentation
- Remove hardcoded "22" rule count from task 5.4 (single-source-of-truth is eslint.config.mjs, not a prose count that goes stale) - Update Phase 3 summary table to reflect PR 5 submission - Replace "PR 20" reference in eslint.config.mjs comment with "type refinement phase" to avoid stale PR number coupling - Remove specific "5 stale" directive count from task 5.7 (exact count is unnecessary and was inaccurate — it was 6)
1 parent 0852f30 commit 041de3f

3 files changed

Lines changed: 4 additions & 4 deletions

File tree

docs/tasks/prd-typescript-migration.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -293,7 +293,7 @@ These are key checkpoints where the executor should perform manual verification
293293
|-------|-------------|-----|--------|
294294
| 1 | TypeScript Infrastructure Setup | 1 (PR 1) | Complete |
295295
| 2 | Type Definitions | 1 (PR 2) | Complete |
296-
| 3 | Tooling Modernization | 7 (PRs 3-8, with 7 split into 7a/7b) | In progress (PRs 3-4 submitted) |
296+
| 3 | Tooling Modernization | 7 (PRs 3-8, with 7 split into 7a/7b) | In progress (PRs 3-5 submitted) |
297297
| 4 | TypeScript File Conversion | 13 (PRs 9-21) | Not started |
298298
| 5 | Test File Conversion | 6 (PRs 22-26, with 25 split into 25a/25b) | Not started |
299299

docs/tasks/tasks-prd-typescript-migration.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -246,13 +246,13 @@ Use Graphite (gt) commands for managing stacked branches:
246246

247247
- [x] 5.3. Install `eslint` 9.x, `typescript-eslint` v8 (unified package), `@eslint/js` 9.x, and `globals`
248248

249-
- [x] 5.4. Create `eslint.config.mjs` (flat config format) with 22 TypeScript rules, JS/TS file scoping, and `src/types/` override for known `any`/`Function` debt. See `eslint.config.mjs` for the authoritative rule list.
249+
- [x] 5.4. Create `eslint.config.mjs` (flat config format) with TypeScript rules, JS/TS file scoping, and `src/types/` override for known `any`/`Function` debt. See `eslint.config.mjs` for the authoritative rule list.
250250

251251
- [x] 5.5. Delete `.eslintrc`, `test/.eslintrc`, and `.eslintignore`
252252

253253
- [x] 5.6. Update `package.json`: lint script (remove `-c .eslintrc`, use `src/` for recursive linting), test script (remove redundant `pnpm run lint` — CI runs lint separately)
254254

255-
- [x] 5.7. Fix lint errors in newly-linted files: `hasOwnProperty``Object.hasOwn()`, removed unused `isObject` function, removed unused `element` param, removed unused `err` binding, cleaned up 5 stale eslint-disable directives
255+
- [x] 5.7. Fix lint errors in newly-linted files: `hasOwnProperty``Object.hasOwn()`, removed unused `isObject` function, removed unused `element` param, removed unused `err` binding, cleaned up stale eslint-disable directives
256256

257257
- [x] 5.8. Verify: `pnpm run lint` passes (0 errors, 0 warnings), `pnpm run testem` passes (794/794), `pnpm run type-check` passes, `pnpm run build` passes
258258

eslint.config.mjs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ export default tseslint.config(
7474
},
7575

7676
// TECH DEBT: src/types/ contains legacy type definitions with `any`, `Function`, and `{}`.
77-
// These suppressions are temporary — removed in PR 20 (type refinement).
77+
// These suppressions are temporary — removed during the type refinement phase.
7878
{
7979
files: ['src/types/**/*.ts'],
8080
rules: {

0 commit comments

Comments
 (0)