From 7fc84d9486a014e0ae567c806cf0980542f66878 Mon Sep 17 00:00:00 2001 From: D3SOX Date: Sun, 8 Nov 2026 14:51:45 +0100 Subject: [PATCH 1/2] feat: allow talking to KWin OpenTubeX restores Picture-in-Picture bounds and detects minimizing on KDE Plasma Wayland through KWin scripts, which it loads over KWin's D-Bus interface. Without this name, the calls fail with ServiceUnknown. --- org.opentubex.OpenTubeX.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/org.opentubex.OpenTubeX.yml b/org.opentubex.OpenTubeX.yml index 46c95f38..3c4b1d4b 100644 --- a/org.opentubex.OpenTubeX.yml +++ b/org.opentubex.OpenTubeX.yml @@ -21,6 +21,7 @@ finish-args: - --talk-name=org.freedesktop.ScreenSaver - --talk-name=org.gnome.SessionManager - --talk-name=org.gnome.SettingsDaemon + - --talk-name=org.kde.KWin - --unset-env=ELECTRON_RUN_AS_NODE modules: - name: opentubex From 52c73298da32ce6a2aa6e126662dd08b528d0826 Mon Sep 17 00:00:00 2001 From: D3SOX Date: Sun, 8 Nov 2026 16:54:53 +0100 Subject: [PATCH 2/2] ci: allow the KWin talk name in the Flathub linter This repository publishes to its own remote, so Flathub's default refusal of org.kde.KWin does not apply. A user exception file keeps every other lint error fatal, and the build job gets the file through the prepared manifest artifact. --- .github/workflows/build.yml | 3 ++- .github/workflows/validate.yml | 2 +- flatpak-builder-lint-exceptions.json | 5 +++++ 3 files changed, 8 insertions(+), 2 deletions(-) create mode 100644 flatpak-builder-lint-exceptions.json diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 4122dd38..b567b208 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -218,6 +218,7 @@ jobs: org.opentubex.OpenTubeX.desktop org.opentubex.OpenTubeX.metainfo.xml run.sh + flatpak-builder-lint-exceptions.json build: name: Build ${{ matrix.arch }} @@ -246,7 +247,7 @@ jobs: - name: Validate Flatpak metadata run: | set -euo pipefail - flatpak-builder-lint manifest org.opentubex.OpenTubeX.yml + flatpak-builder-lint --exceptions --user-exceptions flatpak-builder-lint-exceptions.json manifest org.opentubex.OpenTubeX.yml # Offline, so a github.com outage cannot block a release; validate.yml checks the URLs. appstreamcli validate --no-net --explain org.opentubex.OpenTubeX.metainfo.xml desktop-file-validate org.opentubex.OpenTubeX.desktop diff --git a/.github/workflows/validate.yml b/.github/workflows/validate.yml index 7eeb3550..d928fb9e 100644 --- a/.github/workflows/validate.yml +++ b/.github/workflows/validate.yml @@ -33,7 +33,7 @@ jobs: uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1 - name: Validate manifest - run: flatpak-builder-lint manifest org.opentubex.OpenTubeX.yml + run: flatpak-builder-lint --exceptions --user-exceptions flatpak-builder-lint-exceptions.json manifest org.opentubex.OpenTubeX.yml - name: Validate AppStream metadata run: flatpak-builder-lint appstream org.opentubex.OpenTubeX.metainfo.xml diff --git a/flatpak-builder-lint-exceptions.json b/flatpak-builder-lint-exceptions.json new file mode 100644 index 00000000..2e3d9f89 --- /dev/null +++ b/flatpak-builder-lint-exceptions.json @@ -0,0 +1,5 @@ +{ + "org.opentubex.OpenTubeX": { + "finish-args-kwin-talk-name": "KDE Plasma's Wayland session has no other way to restore the Picture-in-Picture window's position and size or to report when the main window is minimized, so the app loads small KWin scripts for both. This repository publishes to its own remote, not Flathub." + } +}