From bd2475b07cbe33f0a596f210159e24de1d6f89c9 Mon Sep 17 00:00:00 2001 From: Alex Castillo Date: Fri, 13 Nov 2026 02:37:08 -0400 Subject: [PATCH] fix(client): treat empty 2xx body in http_put as success (#370) Signed-off-by: Alex Castillo --- pyoaev/client.py | 3 ++ .../test_inject_expectation.py | 41 +++++++++++++++++++ 2 files changed, 44 insertions(+) diff --git a/pyoaev/client.py b/pyoaev/client.py index f0f295f7..ae21f7ed 100644 --- a/pyoaev/client.py +++ b/pyoaev/client.py @@ -418,6 +418,9 @@ def http_put( raw=raw, **kwargs, ) + if not raw and not result.content: + # void endpoints answer 2xx with an empty body + return {} try: json_result = result.json() if TYPE_CHECKING: diff --git a/test/apis/inject_expectation/test_inject_expectation.py b/test/apis/inject_expectation/test_inject_expectation.py index 3822e89d..ce793f65 100644 --- a/test/apis/inject_expectation/test_inject_expectation.py +++ b/test/apis/inject_expectation/test_inject_expectation.py @@ -370,5 +370,46 @@ def test_older_platform_returns_no_model(self): self.assertEqual([], models) +class TestBulkUpdate(TestCase): + @mock.patch("requests.Session.request") + def test_empty_2xx_body_is_success(self, mock_request): + class EmptyResponse: + status_code = 200 + history = None + content = b"" + headers = {} + + def json(self): + raise ValueError("Expecting value: line 1 column 1 (char 0)") + + mock_request.return_value = EmptyResponse() + api_client = OpenAEV("url", "token") + + result = api_client.inject_expectation.bulk_update( + {"exp-1": {"collector_id": "c-1", "result": "Detected", "is_success": True}} + ) + + self.assertIsNone(result) + _, kwargs = mock_request.call_args + self.assertEqual(kwargs["url"], "url/api/injects/expectations/bulk") + + @mock.patch("requests.Session.request") + def test_non_json_non_empty_body_still_raises(self, mock_request): + class HtmlResponse: + status_code = 200 + history = None + content = b"" + headers = {} + + def json(self): + raise ValueError("Expecting value") + + mock_request.return_value = HtmlResponse() + api_client = OpenAEV("url", "token") + + with self.assertRaises(OpenAEVParsingError): + api_client.inject_expectation.bulk_update({"exp-1": {}}) + + if __name__ == "__main__": main()