From 97f2d9a46ce6653507d939317fd3a4679ad05ad6 Mon Sep 17 00:00:00 2001 From: gregfouillard Date: Fri, 6 Nov 2026 22:33:14 +0100 Subject: [PATCH] refactor: remove asset_group from models and related components --- pyoaev/signatures/models.py | 1 - pyoaev/signatures/signature_manager.py | 3 +-- test/signatures/test_signature_manager_build_payload.py | 2 +- test/signatures/test_signature_manager_transmission.py | 2 -- 4 files changed, 2 insertions(+), 6 deletions(-) diff --git a/pyoaev/signatures/models.py b/pyoaev/signatures/models.py index b6115b8a..feef1c45 100644 --- a/pyoaev/signatures/models.py +++ b/pyoaev/signatures/models.py @@ -109,7 +109,6 @@ class SignatureTarget(BaseModel): agent: str | None = None asset: str | None = None - asset_group: str | None = None class TargetSignatures(BaseModel): diff --git a/pyoaev/signatures/signature_manager.py b/pyoaev/signatures/signature_manager.py index 37f82271..b63b05c2 100644 --- a/pyoaev/signatures/signature_manager.py +++ b/pyoaev/signatures/signature_manager.py @@ -177,7 +177,7 @@ def build_payload( Args: execution_signatures: A single post-execution ExecutionSignature or a list (multi-targets). - targets_meta: Target metadata dict(s) with keys like agent, asset, asset_group. + targets_meta: Target metadata dict(s) with keys like agent, asset. expectation_types: The 1+ expectation type labels (e.g. ['DETECTION', 'PREVENTION']). extra_signatures: Optional mapping of expectation types to additional signature fields that will be merged into the base post_signatures. @@ -221,7 +221,6 @@ def build_payload( signature_target=SignatureTarget( agent=target.agent_id, asset=target.asset_id, - asset_group=target.asset_group_id, ), signature_values=signature_values, ) diff --git a/test/signatures/test_signature_manager_build_payload.py b/test/signatures/test_signature_manager_build_payload.py index a6ecc749..7df12649 100644 --- a/test/signatures/test_signature_manager_build_payload.py +++ b/test/signatures/test_signature_manager_build_payload.py @@ -14,7 +14,7 @@ from pyoaev.signatures.signature_manager import SignatureManager from pyoaev.signatures.types import SignatureTypes -TARGET = SimpleNamespace(agent_id="agent-1", asset_id="asset-1", asset_group_id=None) +TARGET = SimpleNamespace(agent_id="agent-1", asset_id="asset-1") CANONICAL_TYPES = {signature_type.value for signature_type in SignatureTypes} diff --git a/test/signatures/test_signature_manager_transmission.py b/test/signatures/test_signature_manager_transmission.py index b06759b0..c4c5fe06 100644 --- a/test/signatures/test_signature_manager_transmission.py +++ b/test/signatures/test_signature_manager_transmission.py @@ -86,7 +86,6 @@ def context(): _CANONICAL_SIGNATURE_TARGET = { "agent": "b044fbc7-f277-4c8c-aeae-5c5497598c51", "asset": "asset-host-a", - "asset_group": "asset-group-internal", } @@ -239,7 +238,6 @@ def compiled_large_payload(context): "signature_target": { "agent": f"agent-{index:08d}-0000-0000-0000-000000000000", "asset": f"asset-{index}", - "asset_group": "asset-group-bulk", }, "signature_values": [ {