From c6bb84ef302558baf66f8b3e5c9c7d4688f46fb7 Mon Sep 17 00:00:00 2001 From: "Sadie L. Bartholomew" Date: Fri, 13 Nov 2026 10:55:22 +0000 Subject: [PATCH 1/2] Configure CI/Actions to adjust job trigger events for all workflows --- .github/workflows/linting.yml | 12 +++--------- .github/workflows/run-image-comparison.yml | 4 +++- .github/workflows/run-tests.yml | 11 +++-------- 3 files changed, 9 insertions(+), 18 deletions(-) diff --git a/.github/workflows/linting.yml b/.github/workflows/linting.yml index 325507e6..de98ee38 100644 --- a/.github/workflows/linting.yml +++ b/.github/workflows/linting.yml @@ -1,17 +1,11 @@ # A GitHub Action to lint the cf-plot codebase. name: Linting and code formatting as per pre-commit checks -# Trigger on PR events targeting main. +# Trigger on all commits for any branch on: - # For now, do not enable on push to save on limited usage resource. - # push: - # branches: - # - main - pull_request: - # 'reopened' enables manual retrigger via close & re-open. - types: [opened, reopened, ready_for_review] + push: branches: - - main + - '**' permissions: contents: read diff --git a/.github/workflows/run-image-comparison.yml b/.github/workflows/run-image-comparison.yml index cc255ef9..0e8248a3 100644 --- a/.github/workflows/run-image-comparison.yml +++ b/.github/workflows/run-image-comparison.yml @@ -1,9 +1,11 @@ # Run cf-plot tests including image comparison, in the reference environment name: Run image comparison testing +# Trigger on main PRs when (re-)opened, marked ready for review, and with any +# push of commits on the latest state of the PR branch after opening on: pull_request: - types: [opened, reopened, ready_for_review] + types: [opened, synchronize, reopened, ready_for_review] branches: - main diff --git a/.github/workflows/run-tests.yml b/.github/workflows/run-tests.yml index f77670d3..74a9016b 100644 --- a/.github/workflows/run-tests.yml +++ b/.github/workflows/run-tests.yml @@ -2,16 +2,11 @@ # A GitHub Action to run the cf-plot test suite after PR events on main. name: Run all testing excluding image comparison aspect -# Triggers the workflow on PR events targeting main. +# Trigger on main PRs when (re-)opened, marked ready for review, and with any +# push of commits on the latest state of the PR branch after opening on: - # For now, at least, do not enable on push to save on limited usage resource - #push: - # branches: - # - main pull_request: - # 'reopened' enables manual retrigger via close & re-open. Disable for all - # edits to manage limited resource (PRs often change before merge-ready). - types: [opened, reopened, ready_for_review] + types: [opened, synchronize, reopened, ready_for_review] branches: - main From 623617469b7483ba20cd31a50086cd0e04ee4652 Mon Sep 17 00:00:00 2001 From: "Sadie L. Bartholomew" Date: Fri, 13 Nov 2026 11:01:26 +0000 Subject: [PATCH 2/2] Update linting CI workflow to run on PR as well as push events --- .github/workflows/linting.yml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/.github/workflows/linting.yml b/.github/workflows/linting.yml index de98ee38..56b1b010 100644 --- a/.github/workflows/linting.yml +++ b/.github/workflows/linting.yml @@ -6,6 +6,10 @@ on: push: branches: - '**' + pull_request: + types: [opened, synchronize, reopened, ready_for_review] + branches: + - main permissions: contents: read