diff --git a/xExtension-ReadingTime/README.md b/xExtension-ReadingTime/README.md index 24fba010..f30517f7 100644 --- a/xExtension-ReadingTime/README.md +++ b/xExtension-ReadingTime/README.md @@ -1,6 +1,6 @@ Extension pour FreshRSS () -> **v1.6** +> **v1.7** Ajoute une estimation du temps de lecture à côté de chaque article. Fonctionne sur les affichages de bureau et mobile. @@ -10,12 +10,13 @@ Aucune module externe. Une fois activée dans les préférences, l'extension doi Un indicateur du temps de lecture doit s'afficher dans le nom du flux de chaque article. Vous pouvez définir la vitesse de lecture et la méthode de mesure du temps de lecture. +Aucun temps de lecture n'est affiché pour les vidéos YouTube, car leur durée n'est pas fournie par le flux. --- Extension for FressRSS () -> **v1.6** +> **v1.7** Add a reading time estimation next to each article. Works on both desktop and mobile displays. @@ -24,3 +25,4 @@ Install it the same way as any other extension, with the integrated tool in the No external module. Once activated in the preferences, this extension should be working after reloading the page. You can set reading speed and source metrics to estimate reading time. +No reading time is shown for YouTube videos, as their duration is not provided by the feed. diff --git a/xExtension-ReadingTime/metadata.json b/xExtension-ReadingTime/metadata.json index f4db9143..d49c5d7a 100644 --- a/xExtension-ReadingTime/metadata.json +++ b/xExtension-ReadingTime/metadata.json @@ -2,7 +2,7 @@ "name": "ReadingTime", "author": "Lapineige, hkcomori", "description": "Add a reading time estimation next to each article", - "version": "1.6.3", + "version": "1.7.0", "entrypoint": "ReadingTime", "type": "user" } diff --git a/xExtension-ReadingTime/static/readingtime.js b/xExtension-ReadingTime/static/readingtime.js index bd4e029d..7b6aa842 100644 --- a/xExtension-ReadingTime/static/readingtime.js +++ b/xExtension-ReadingTime/static/readingtime.js @@ -22,12 +22,17 @@ reading_time.flux = flux_list[i]; - if (metrics == 'letters') { - reading_time.count = reading_time.flux_letters_count(flux_list[i], language); - } else { // words - reading_time.count = reading_time.flux_words_count(flux_list[i]); + if (reading_time.is_youtube_video(flux_list[i])) { + // YouTube feeds provide only the description of the video, which says nothing about how long it takes to watch it + reading_time.reading_time = ''; + } else { + if (metrics == 'letters') { + reading_time.count = reading_time.flux_letters_count(flux_list[i], language); + } else { // words + reading_time.count = reading_time.flux_words_count(flux_list[i]); + } + reading_time.reading_time = reading_time.calc_read_time(reading_time.count, speed); } - reading_time.reading_time = reading_time.calc_read_time(reading_time.count, speed); flux_list[i].dataset.readingTime = reading_time.reading_time; @@ -37,13 +42,21 @@ li.style.overflow = 'hidden'; li.style.textAlign = 'right'; li.style.display = 'table-cell'; - li.textContent = reading_time.reading_time + '\u2009m'; + if (reading_time.reading_time !== '') { // Keep the empty cell of videos, to align the columns of the articles + li.textContent = reading_time.reading_time + '\u2009m'; + } const ul = document.querySelector('#' + reading_time.flux.id + ' ul.horizontal-list'); ul.insertBefore(li, ul.children[ul.children.length - 1]); } }, + is_youtube_video: function is_youtube_video(flux) { + // `data-link` is only available since FreshRSS 1.28 + const link = flux.dataset.link || flux.querySelector('.flux_content .go_website')?.getAttribute('href') || ''; + return /^https?:\/\/(?:(?:(?:www|m|music)\.)?youtube\.com\/(?:watch\?|shorts\/|live\/)|youtu\.be\/)/i.test(link); + }, + flux_words_count: function flux_words_count(flux) { // get textContent, from the article itself (not the header, not the bottom line): reading_time.textContent = flux.querySelector('.flux_content .content').textContent;