Skip to content

Android DefaultPushNotificationHandler "silent" flag not case sensitive #170

Description

@bPoller2810

The DefaultPushNotificationHandler for Android in method "void OnReceived(IDictionary<string, object> parameters)" does a calue check in line 151 for the key "silent". The Values to be a valid silent Notification are "true" and "1".

in my Case the resulting Value was "True" and the Handler resulted in unexpected behaviour.

This check should be made case sensitive (either with one more check or a "ToLower()" )

To the Maintainers:

  • Is this something you would consider a improvement?
  • Would you like to implement this for yourself or do you prefer a PullRequest?

PS: i should not forget to mention: if the app is in background this "behaviour" freezes the Android app completly. (a exception only occured 1 out of ~60 tests for me)

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions