Skip to content
This repository was archived by the owner on Aug 10, 2021. It is now read-only.
This repository was archived by the owner on Aug 10, 2021. It is now read-only.

Reimplement a location picker #1

Description

@paride

Signal's location picker relies on the proprietary Play Services and has been removed from Cable. The feature is missing and has to be re-implemented using free libraries, possibly using OpenStreeMap. Useful notes:

  • The location code has not been removed, but commented out, adding the Location-TODO string to the comment, so it's easy to find where the relevant code is. The three files SignalMapView.java, SignalPlace.java, LocationSlide.java, have been renamed to .java.nogms.
  • The location picker should not rely on OsmAnd (or any other app) being installed.
  • The URL has to be shared using standard geo: URIs.
  • A linkifier for geo: URIs has to be added (a PR implementing this has been submitted to Signal, but it has been rejected, see below).

Relevant Signal issues and PR:

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions